beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-777) KafkaIO Test should handle reader.start() better
Date Wed, 19 Oct 2016 04:53:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587684#comment-15587684
] 

ASF GitHub Bot commented on BEAM-777:
-------------------------------------

GitHub user rangadi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1133

    [BEAM-777] KafkaIOTest : reader.start() can return false

    KafkaIOTest expected reader.start() to always return true. It could return false as well
(though most of the time it would succeed with MockConsumer).
    
    updated `advanceOnce()` utility method to`start()` the reader based on a flag.
    
    R: @dhalperi, R: @amitsela.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rangadi/incubator-beam fix_start

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1133
    
----
commit 068e458d10c901fe1c299dffe84b75c9c842095c
Author: Raghu Angadi <rangadi@google.com>
Date:   2016-10-19T04:46:18Z

    KafkaIOTest : start() can return false

----


> KafkaIO Test should handle reader.start() better
> ------------------------------------------------
>
>                 Key: BEAM-777
>                 URL: https://issues.apache.org/jira/browse/BEAM-777
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>
> KafkaIOTest currently expects reader.start() to return true. It can return false as well.
It should handle it better. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message