beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-771) UnboundedReadEvaluator should reuse the input reader if it contains no elements
Date Tue, 18 Oct 2016 18:04:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586181#comment-15586181
] 

ASF GitHub Bot commented on BEAM-771:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1128

    [BEAM-771] Add a Residual Shard for Empty Readers

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    When the UnboundedReadEvaluator starts, it checks to see if the reader
    has any elements available. If not, it immediately terminates (without
    taking a new checkpoint). It should also ensure that the result contains
    a residual shard that will continue to read from the shard, utilizing
    the same reader if possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam read_when_no_inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1128
    
----
commit 87f26972c02bb7640c1eee5069ad842a4a3ab1a0
Author: Thomas Groh <tgroh@google.com>
Date:   2016-10-18T17:57:53Z

    Add a Residual Shard for Empty Readers
    
    When the UnboundedReadEvaluator starts, it checks to see if the reader
    has any elements available. If not, it immediately terminates (without
    taking a new checkpoint). It should also ensure that the result contains
    a residual shard that will continue to read from the shard, utilizing
    the same reader if possible.

----


> UnboundedReadEvaluator should reuse the input reader if it contains no elements
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-771
>                 URL: https://issues.apache.org/jira/browse/BEAM-771
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> The UnboundedReadEvaluator checks, after it obtains the reader, that the reader contains
elements, and terminates without taking a new checkpoint if not. It must also (but currently
does not) add that reader and shard back as a residual element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message