beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-747) Text checksum verifier is not resilient to eventually consistent filesystems
Date Fri, 14 Oct 2016 06:44:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574437#comment-15574437
] 

Kenneth Knowles commented on BEAM-747:
--------------------------------------

Side note: we should treat checksums as a shortcut for a quick positive match. When they fail
to match, the full diff should then be computed and dumped, so the error is actionable. I
recent saw a message like like "checksum <x> was not <y>" with no following information.

> Text checksum verifier is not resilient to eventually consistent filesystems
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-747
>                 URL: https://issues.apache.org/jira/browse/BEAM-747
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>            Assignee: Mark Liu
>
> Example 1: https://builds.apache.org/job/beam_PreCommit_MavenVerify/3934/org.apache.beam$beam-examples-java/console
> Here it looks like we need to retry listing files, at least a little bit, if none are
found. They did show up:
> {code}
> gsutil ls gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-13-12-37-02-467/output/results\*
> gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-13-12-37-02-467/output/results-00000-of-00003
> gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-13-12-37-02-467/output/results-00001-of-00003
> gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-13-12-37-02-467/output/results-00002-of-00003
> {code}
> Example 2: https://builds.apache.org/job/beam_PostCommit_MavenVerify/org.apache.beam$beam-examples-java/1525/testReport/junit/org.apache.beam.examples/WordCountIT/testE2EWordCount/
> Here it looks like we need to fill in the shard template if the filesystem does not give
us a consistent result:
> {code}
> Oct 14, 2016 12:31:16 AM org.apache.beam.sdk.testing.FileChecksumMatcher readLines
> INFO: [0 of 1] Read 162 lines from file: gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-14-00-25-55-609/output/results-00000-of-00003
> Oct 14, 2016 12:31:16 AM org.apache.beam.sdk.testing.FileChecksumMatcher readLines
> INFO: [1 of 1] Read 144 lines from file: gs://temp-storage-for-end-to-end-tests/WordCountIT-2016-10-14-00-25-55-609/output/results-00002-of-00003
> Oct 14, 2016 12:31:16 AM org.apache.beam.sdk.testing.FileChecksumMatcher matchesSafely
> INFO: Generated checksum for output data: aec68948b2515e6ea35fd1ed7649c267a10a01e5
> {code}
> We missed shard 1-of-3 and hence got the wrong checksum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message