beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pei He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-586) CombineFns with no inputs should produce no outputs when used as a main input
Date Tue, 04 Oct 2016 20:08:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546500#comment-15546500
] 

Pei He commented on BEAM-586:
-----------------------------

Is that fair to say triggering defines whether and when CombineFns output, and CombineFns
define what to output given a collection of inputs (could be empty)?

If this is what we want to do (I am not sure if it is right), possible options are:
1. triggering doesn't output empty pane.
or 2. CombineFns output nothing for an empty input collection.

I would prefer not to differentiate main input and side input.

> CombineFns with no inputs should produce no outputs when used as a main input
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-586
>                 URL: https://issues.apache.org/jira/browse/BEAM-586
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>
> TestGloballyEmptyCollection seems to be violating this assumption
> https://github.com/apache/incubator-beam/pull/862/files#diff-a305819710e8d79d2b045d6416184f21R65




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message