beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-525) Verify that ParDo with multiple outputs with tags un declared in with_outputs() work
Date Thu, 27 Oct 2016 16:47:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612466#comment-15612466
] 

ASF GitHub Bot commented on BEAM-525:
-------------------------------------

GitHub user pabloem opened a pull request:

    https://github.com/apache/incubator-beam/pull/1209

    [BEAM-525] Remove superflous TODO in dataflow_test

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pabloem/incubator-beam remove-dftst-todo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1209
    
----
commit 34f6236ad3536cc69dec01d02f0b83218be56d42
Author: Pablo <pabloem@google.com>
Date:   2016-10-27T16:38:59Z

    Removing superfluous TODO after unittest is passing

----


> Verify that ParDo with multiple outputs with tags un declared in with_outputs() work

> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-525
>                 URL: https://issues.apache.org/jira/browse/BEAM-525
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>
> test_undeclared_side_outputs was failing (when last checked) under certain conditions:
> See this TODO:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/dataflow_test.py#L202
> This is probably not failing any more but it needs to be verified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message