beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geetha Bijjam (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-520) Update Python SDK example tests to use assert_that
Date Fri, 14 Oct 2016 18:42:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576063#comment-15576063
] 

Geetha Bijjam edited comment on BEAM-520 at 10/14/16 6:41 PM:
--------------------------------------------------------------

Thanks for the info.
I am working on multiple_output_pardo_test.py.

PR: (https://github.com/apache/incubator-beam/pull/1108)

Travis build in failing in a totally different file: /bin/python apache_beam/examples/complete/autocomplete_test.py

Please find the travis logs here:
https://api.travis-ci.org/jobs/167721614/log.txt?deansi=true


was (Author: venbijjam):
Thanks for the info.
I am working on multiple_output_pardo_test.py and will send a PR once the Travis Build succeeds.

Travis build in failing in a totally different file: /bin/python apache_beam/examples/complete/autocomplete_test.py

Please find the travis logs here:
https://api.travis-ci.org/jobs/167721614/log.txt?deansi=true

> Update Python SDK example tests to use assert_that
> --------------------------------------------------
>
>                 Key: BEAM-520
>                 URL: https://issues.apache.org/jira/browse/BEAM-520
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>              Labels: starter
>
> Most of our examples use assert_that to test examples:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/complete/autocomplete_test.py#L38
> Some of our examples use this pattern:
> 1) Create a path(s)
> 2) Construct fake command line arguments using these paths
> 3) Construct an argparse object to parse these flags
> 4) Do the (often trivial logic)
> 5) Write to a file
> 6) Manually open and read the file
> 7) Compare results. 
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py
> As well as being cumbersome, this obscures the core of what is being illustrated and
tested. As many as possible tests should be updated to use assert_that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message