beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Altay (JIRA)" <>
Subject [jira] [Commented] (BEAM-520) Update Python SDK example tests to use assert_that
Date Thu, 13 Oct 2016 20:37:20 GMT


Ahmet Altay commented on BEAM-520:

Ven, thank you for your interest.

A partial cleanup was already done in an earlier PR (
Take a look at that. Similar changes needs to happen in the remaining tests (e.g.
Convert as many tests/examples as possible to the assert_that pattern and send a PR.

If you are not familiar, you can also look at Beam contribution guide (
for the general workflow of working with Beam.

> Update Python SDK example tests to use assert_that
> --------------------------------------------------
>                 Key: BEAM-520
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>              Labels: starter
> Most of our examples use assert_that to test examples:
> Some of our examples use this pattern:
> 1) Create a path(s)
> 2) Construct fake command line arguments using these paths
> 3) Construct an argparse object to parse these flags
> 4) Do the (often trivial logic)
> 5) Write to a file
> 6) Manually open and read the file
> 7) Compare results. 
> As well as being cumbersome, this obscures the core of what is being illustrated and
tested. As many as possible tests should be updated to use assert_that.

This message was sent by Atlassian JIRA

View raw message