beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
Date Mon, 24 Oct 2016 23:11:59 GMT


ASF GitHub Bot commented on BEAM-498:

GitHub user kennknowles opened a pull request:

    [BEAM-498] Remove some more uses of OldDoFn

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @tgroh 
    In the DirectRunner tests, I ported the syntax, though not the logic since it doesn't
actually run yet. I'm not totally certain these tests are needed beyond future ROS tests.

You can merge this pull request into a Git repository by running:

    $ git pull ValueWithRecordId

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1178
commit 3a2f5d1c720590eabee7667b686533f762698297
Author: Kenneth Knowles <>
Date:   2016-10-24T22:57:18Z

    Remove use of OldDoFn in ValueWithRecordId

commit 4219bb5493c3b9f70ccdf78d8820649453cf0a6d
Author: Kenneth Knowles <>
Date:   2016-10-24T23:09:13Z

    Remove use of OldDoFn from some DirectRunner tests


> Make DoFnWithContext the new DoFn
> ---------------------------------
>                 Key: BEAM-498
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible

This message was sent by Atlassian JIRA

View raw message