beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
Date Thu, 20 Oct 2016 04:34:58 GMT


ASF GitHub Bot commented on BEAM-498:

GitHub user kennknowles opened a pull request:

    [BEAM-498] Add unwrapped access to new DoFn in ParDo and use it in the DirectRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    There is one known test failure, where the restriction coder for a single-output splittable
`DoFn` cannot be determined because some type descriptor/token has been wiped out to just
    R: @bjchambers @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull DoFnRunner

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1141
commit 88d89dc46f3b58edda2e8da231dc19fbf860300d
Author: Kenneth Knowles <>
Date:   2016-10-10T21:30:53Z

    Simplify DoFnRunners to be somewhat compositional

commit cb59fa95d7c0931794929bae46af5e313c7e9d97
Author: Kenneth Knowles <>
Date:   2016-10-20T03:08:26Z

    Rename SimpleDoFnRunner to SimpleOldDoFnRunner and remove public access

commit b19f17193d17bfcf3e04faad5a6ce8d323c3d155
Author: Kenneth Knowles <>
Date:   2016-10-20T03:38:23Z

    Add SimpleDoFnRunner for new DoFn and construction via DoFnRunners

commit 2624758cd9adcd837b308d35a14b88b49525a965
Author: Kenneth Knowles <>
Date:   2016-10-20T03:44:52Z

    Add OldDoFn.toDoFn() adapter

commit 9a3ef2a404e4b512e33a33dd2b679b416de28a91
Author: Kenneth Knowles <>
Date:   2016-10-20T03:47:26Z

    Add access to original DoFn on ParDo

commit 10998fdd1a33f468a4c8f5dc71b92e3ed96e8422
Author: Kenneth Knowles <>
Date:   2016-10-20T04:31:25Z

    Switch the DirectRunner to use new DoFns directly


> Make DoFnWithContext the new DoFn
> ---------------------------------
>                 Key: BEAM-498
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles

This message was sent by Atlassian JIRA

View raw message