beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
Date Tue, 25 Oct 2016 12:18:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605173#comment-15605173
] 

Jason White commented on BEAM-410:
----------------------------------

+1

> ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
> --------------------------------------------------------------------
>
>                 Key: BEAM-410
>                 URL: https://issues.apache.org/jira/browse/BEAM-410
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Neelesh Srinivas Salian
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]:
Class defines compareTo(...) and uses Object.equals()
> Applies to: [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627].
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message