beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [07/50] [abbrv] incubator-beam git commit: Fix ReduceFnRunner.cancelEndOfWindowAndGarbageCollectionTimers()
Date Wed, 26 Oct 2016 16:43:45 GMT
Fix ReduceFnRunner.cancelEndOfWindowAndGarbageCollectionTimers()

Before, it was only removing the end-of-window timer. Now, it also
removed that GC timer.


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/59f042c8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/59f042c8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/59f042c8

Branch: refs/heads/gearpump-runner
Commit: 59f042c85a7265d95620afd5aea565416cd35ff9
Parents: caf1fb7
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Authored: Mon Oct 24 10:36:20 2016 +0200
Committer: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Committed: Mon Oct 24 10:39:07 2016 +0200

----------------------------------------------------------------------
 .../src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/59f042c8/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java
b/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java
index 78c4e0b..66fb27c 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java
@@ -943,7 +943,7 @@ public class ReduceFnRunner<K, InputT, OutputT, W extends BoundedWindow>
impleme
     directContext.timers().deleteTimer(eow, TimeDomain.EVENT_TIME);
     Instant gc = garbageCollectionTime(directContext.window());
     if (gc.isAfter(eow)) {
-      directContext.timers().deleteTimer(eow, TimeDomain.EVENT_TIME);
+      directContext.timers().deleteTimer(gc, TimeDomain.EVENT_TIME);
     }
   }
 


Mime
View raw message