Return-Path: <commits-return-9118-archive-asf-public=cust-asf.ponee.io@beam.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 5FA69200B78
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  2 Sep 2016 22:44:08 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 5C85A160AAE; Fri,  2 Sep 2016 20:44:08 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A46A6160A8C
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  2 Sep 2016 22:44:07 +0200 (CEST)
Received: (qmail 64303 invoked by uid 500); 2 Sep 2016 20:44:06 -0000
Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.incubator.apache.org>
List-Post: <mailto:commits@beam.incubator.apache.org>
List-Id: <commits.beam.incubator.apache.org>
Reply-To: dev@beam.incubator.apache.org
Delivered-To: mailing list commits@beam.incubator.apache.org
Received: (qmail 64294 invoked by uid 99); 2 Sep 2016 20:44:06 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 20:44:06 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 623B4C3B1D
	for <commits@beam.apache.org>; Fri,  2 Sep 2016 20:44:06 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.539
X-Spam-Level: 
X-Spam-Status: No, score=-4.539 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.519] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id nxtx849JwG-t for <commits@beam.apache.org>;
	Fri,  2 Sep 2016 20:44:05 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 37DC95FAE7
	for <commits@beam.incubator.apache.org>; Fri,  2 Sep 2016 20:44:04 +0000 (UTC)
Received: (qmail 64276 invoked by uid 99); 2 Sep 2016 20:44:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 20:44:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 3F2C8DFCC0; Fri,  2 Sep 2016 20:44:04 +0000 (UTC)
From: markflyhigh <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-916-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #916: [BEAM-604] Use Watermark to Finish Streami...
Content-Type: text/plain
Date: Fri,  2 Sep 2016 20:44:04 +0000 (UTC)
archived-at: Fri, 02 Sep 2016 20:44:08 -0000

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/916

    [BEAM-604] Use Watermark to Finish Streaming Job in TestDataflowRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
     - Add checkMaxWatermark() function in TestDataflowRunner, so that when testing on streaming pipeline with bounded input, the job can be canceled as soon as all watermark reach to max value (by default is -2). Then, verification steps can be executed.
     - Add WindowedWordCountIT as a basic example of testing on streaming job.
     - Add non-terminated check before canceling steaming job.
    
    TODO:
     - Create verifier for WindowedWordCountIT. (BigQuery verifier)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam streaming-wait-until-max-watermark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #916
    
----
commit bb8a6f8a360a8f263fe0ad625ab4159d645c42ab
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-09-02T20:22:37Z

    [BEAM-604] Use Watermark to Finish Streaming Job in TestDataflowRunner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---