Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CAD33200B88 for ; Thu, 22 Sep 2016 22:13:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C952C160AAD; Thu, 22 Sep 2016 20:13:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1905F160AA9 for ; Thu, 22 Sep 2016 22:13:25 +0200 (CEST) Received: (qmail 22626 invoked by uid 500); 22 Sep 2016 20:13:25 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 22617 invoked by uid 99); 22 Sep 2016 20:13:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 20:13:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E6588C03BC for ; Thu, 22 Sep 2016 20:13:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YuVfoMXSS3eP for ; Thu, 22 Sep 2016 20:13:24 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 510CE5FABF for ; Thu, 22 Sep 2016 20:13:23 +0000 (UTC) Received: (qmail 21893 invoked by uid 99); 22 Sep 2016 20:13:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 20:13:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7546F2C2A63 for ; Thu, 22 Sep 2016 20:13:22 +0000 (UTC) Date: Thu, 22 Sep 2016 20:13:22 +0000 (UTC) From: "Luke Cwik (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-670) FluentBackoff incorrectly handles nextBackOff millis MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 22 Sep 2016 20:13:27 -0000 Luke Cwik created BEAM-670: ------------------------------ Summary: FluentBackoff incorrectly handles nextBackOff millis Key: BEAM-670 URL: https://issues.apache.org/jira/browse/BEAM-670 Project: Beam Issue Type: Bug Components: sdk-java-gcp Reporter: Luke Cwik Assignee: Daniel Halperin Priority: Minor From: https://github.com/GoogleCloudPlatform/DataflowJavaSDK/commit/94d57207924ed8650cf3c97fccb2a45f27bcc6a3#commitcomment-19135952 Also present in: https://github.com/apache/incubator-beam/pull/888/files#diff-f6d45f28c12083c9556bb410bde8b109R614 The check is inverted, it should be nextBackoffMillis != BackOff.STOP Otherwise it causes Thread.sleep() to be called with value -1 which causes an IllegalArgumentException exception to be thrown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)