Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2885200B95 for ; Tue, 27 Sep 2016 23:58:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A10CD160AD2; Tue, 27 Sep 2016 21:58:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E7B60160AB9 for ; Tue, 27 Sep 2016 23:58:23 +0200 (CEST) Received: (qmail 7326 invoked by uid 500); 27 Sep 2016 21:58:23 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 7317 invoked by uid 99); 27 Sep 2016 21:58:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 21:58:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BE1D11A5DB7 for ; Tue, 27 Sep 2016 21:58:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JPpvsZmLoCEu for ; Tue, 27 Sep 2016 21:58:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id CF3875F4E5 for ; Tue, 27 Sep 2016 21:58:21 +0000 (UTC) Received: (qmail 6479 invoked by uid 99); 27 Sep 2016 21:58:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 21:58:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DE6DF2C2A67 for ; Tue, 27 Sep 2016 21:58:20 +0000 (UTC) Date: Tue, 27 Sep 2016 21:58:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-559) DoFnTester should handle Setup / TearDown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Sep 2016 21:58:24 -0000 [ https://issues.apache.org/jira/browse/BEAM-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527536#comment-15527536 ] ASF GitHub Bot commented on BEAM-559: ------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-beam/pull/1011 > DoFnTester should handle Setup / TearDown > ----------------------------------------- > > Key: BEAM-559 > URL: https://issues.apache.org/jira/browse/BEAM-559 > Project: Beam > Issue Type: Improvement > Reporter: Vikas Kedigehalli > Assignee: Eugene Kirpichov > > Now that DoFn supports setup and teardown, it would be nice for DoFnTester to add them to its lifecycle so as to avoid calling these methods explicitly in DoFn unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)