beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #916: [BEAM-604] Use Watermark to Finish Streami...
Date Fri, 02 Sep 2016 20:44:04 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/916

    [BEAM-604] Use Watermark to Finish Streaming Job in TestDataflowRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
     - Add checkMaxWatermark() function in TestDataflowRunner, so that when testing on streaming
pipeline with bounded input, the job can be canceled as soon as all watermark reach to max
value (by default is -2). Then, verification steps can be executed.
     - Add WindowedWordCountIT as a basic example of testing on streaming job.
     - Add non-terminated check before canceling steaming job.
    
    TODO:
     - Create verifier for WindowedWordCountIT. (BigQuery verifier)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam streaming-wait-until-max-watermark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #916
    
----
commit bb8a6f8a360a8f263fe0ad625ab4159d645c42ab
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-09-02T20:22:37Z

    [BEAM-604] Use Watermark to Finish Streaming Job in TestDataflowRunner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message