beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1019: Refactor BundleFactory methods
Date Tue, 27 Sep 2016 20:15:20 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1019

    Refactor BundleFactory methods

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Remove the inputBundle parameter to createBundle and createKeyedBundle.
    This parameter is unless the model is capable of propagating keys
    between PTransforms.
    
    Remove the PCollection parameter to createRootBundle. createRootBundle
    should be a par
    
    Make [Un]CommmittedBundle#getPCollection nullable. Bundles are utilized
    by the runner to control the processing of elements, but may not always
    belong to a PCollection. Update ImmutabilityCheckingBundleFactory to
    return an underlying bundle as the result of createRootBundle.
    
    Use createBundle in Root transform evaluators.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam rm_root_bundle_argument

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1019
    
----
commit 7028d9bef52d3a713cb058f6ece8f73530a3717b
Author: Thomas Groh <tgroh@google.com>
Date:   2016-09-27T20:06:35Z

    Refactor BundleFactory methods
    
    Remove the inputBundle parameter to createBundle and createKeyedBundle.
    This parameter is unless the model is capable of propagating keys
    between PTransforms.
    
    Remove the PCollection parameter to createRootBundle. createRootBundle
    should be a par
    
    Make [Un]CommmittedBundle#getPCollection nullable. Bundles are utilized
    by the runner to control the processing of elements, but may not always
    belong to a PCollection. Update ImmutabilityCheckingBundleFactory to
    return an underlying bundle as the result of createRootBundle.
    
    Use createBundle in Root transform evaluators.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message