beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-517) Check versions of pip and cython
Date Tue, 27 Sep 2016 09:47:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525627#comment-15525627
] 

ASF GitHub Bot commented on BEAM-517:
-------------------------------------

GitHub user mbuccini opened a pull request:

    https://github.com/apache/incubator-beam/pull/1017

    Beam 517 - Check versions of pip and cython

    I have added a check so that the setup fails if pip <= 0.7.0 is not installed. 
    
    In addition, I have added cython as an optional dependency, so that it's installed only
if the user decides to do so, e.g., via 
    
    `pip install -e .[cython]`
    
    The Readme file has also been updated, although I think that it may need some refactoring
in the future, when/if the project is packaged and deployed on pypi as apache-beam. In that
case, it would be possible to execute something like:
    
    `pip install apache-beam[cython]`
    
    ---
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    For more details about the issue, see the jira issue: https://issues.apache.org/jira/browse/BEAM-517

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbuccini/incubator-beam beam-517

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1017
    
----
commit 588b4a35c6d20ade7965c187887c83515eef16c1
Author: mbuccini <mbuccini@talend.com>
Date:   2016-09-27T08:30:38Z

    Fixed pip requirement and set cython as extra package.

commit 66caeb8c6276e2b349ed68f161e85dc910d515a9
Author: mbuccini <mbuccini@talend.com>
Date:   2016-09-27T08:50:16Z

    fixed README for cython/pip versions

commit cb4efec4cc1c400b24e062b007374c0dd7b33aa6
Author: mbuccini <mbuccini@talend.com>
Date:   2016-09-27T08:54:56Z

    Fixed anchors/titles

commit c168e69491d0c1df8aeed0574dee75e375dea27f
Author: mbuccini <mbuccini@talend.com>
Date:   2016-09-27T08:57:14Z

    Fixed typo

commit 8adbd8f4ea18b0d91a5c55914fed31d5b3f70c12
Author: mbuccini <mbuccini@talend.com>
Date:   2016-09-27T09:34:05Z

    Removed section about clone/install Apache Beam

----


> Check versions of pip and cython
> --------------------------------
>
>                 Key: BEAM-517
>                 URL: https://issues.apache.org/jira/browse/BEAM-517
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>              Labels: starter
>
> Python SDK depends on pip and cython however it does not check the versions of these.
> Some of the pip flags does not exist in older versions:
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/28#issuecomment-236382953
> (Note: Even though the above issue was reported by the user in a different repo it is
related to the apache beam sdk)
> Similarly with cython, SDK supports running with or without Cython. Because of that reason
it is not list it as a requirement in the setup.py file. However, with an old version of cython
SDK might fail.
> To avoid the above problem: In the SDK check the version of these packages and show a
warning to upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message