beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-469) NullableCoder should encode using the context given and not always use the nested context
Date Fri, 23 Sep 2016 16:00:21 GMT

    [ https://issues.apache.org/jira/browse/BEAM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516832#comment-15516832
] 

ASF GitHub Bot commented on BEAM-469:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/992

    [BEAM-469] Do not modify the context in NullableCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The NullableCoder does not encode any elements after the subcoder
    encodes the input value for non-null values. As a result, the subcoder
    should see the entire input stream if it is available.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam nullable_non_nested

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/992.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #992
    
----
commit e9737ed446bd7c3ba566a3cf148b6a29bcb544c8
Author: Thomas Groh <tgroh@google.com>
Date:   2016-09-23T15:58:07Z

    Do not modify the context in NullableCoder
    
    The NullableCoder does not encode any elements after the subcoder
    encodes the input value for non-null values. As a result, the subcoder
    should see the entire input stream if it is available.

----


> NullableCoder should encode using the context given and not always use the nested context
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-469
>                 URL: https://issues.apache.org/jira/browse/BEAM-469
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Trivial
>             Fix For: Not applicable
>
>
> NullableCoder should encode using the context given and not always use the nested context.
For coders which can efficiently encode in the outer context such as StringUtf8Coder or ByteArrayCoder,
we are forcing them to prefix themselves with their length.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message