beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-242) Enable Checkstyle check and Javadoc build for the Flink Runner
Date Tue, 06 Sep 2016 05:51:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466509#comment-15466509
] 

ASF GitHub Bot commented on BEAM-242:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/919

    [BEAM-242] Enable and fix checkstyle in Flink runner examples

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Enable and fix checkstyle in Flink runner examples.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-242-FLINK-EXAMPLES

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/919.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #919
    
----
commit 7c01677b10452e4cc36d1d69abae4cd1805c8977
Author: Jean-Baptiste Onofré <jbonofre@apache.org>
Date:   2016-09-06T05:26:45Z

    [BEAM-242] Enable and fix checkstyle in Flink runner examples

----


> Enable Checkstyle check and Javadoc build for the Flink Runner 
> ---------------------------------------------------------------
>
>                 Key: BEAM-242
>                 URL: https://issues.apache.org/jira/browse/BEAM-242
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Maximilian Michels
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>
> We don't have a Checkstyle check in place for the Flink Runner. I would like to use the
SDK's checkstyle rules.
> We could also think about a unified Checkstyle for all Runners.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message