beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sammcveety <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #852: Correctly type collections in PipelineOpti...
Date Fri, 23 Sep 2016 21:27:11 GMT
GitHub user sammcveety reopened a pull request:

    https://github.com/apache/incubator-beam/pull/852

    Correctly type collections in PipelineOptions.

    @bjchambers @lukecwik I would expect this to work, but the cast to ParameterizedType fails.
 Luke, were you suggesting something else?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/fix_generic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #852
    
----
commit bbb8e5a704564b989c8a19941b610e14c685e3c5
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:49:05Z

    Correctly type collections in PipelineOptions.

commit 9dc397915d2055b8be89abb92ccb2c8c7872a294
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:53:29Z

    Minor fix.

commit 77c77f0010142c65f896aa4a431bd50ab7e45f96
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:54:16Z

    Minor fix.

commit 4c273142a8b7cd6fcee7e094db6ddb94fa99fef4
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T14:19:05Z

    Demonstrate how to fix generic issue.

commit be772844864486a2d60b9362b0d45890bdc5c920
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T14:35:40Z

    Fix handling of typed collections.

commit 7126afdf40ae5a83191394e330a85f4f1157eb67
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T17:26:06Z

    Add more tests and remove redundant logic.

commit 42e2c620bb1f9e6cbcc9f6135d9a69ff9173e613
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T17:28:43Z

    Update comment.

commit 2b843bdea4b4998549c2975265b17b5f7ad9caa2
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T17:32:32Z

    Make empty non-strings an error.

commit a3b236c064e0a44c2c11c6185ee0b2f2fcde6e4f
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T17:46:45Z

    Use allInterfaceMethods logic.

commit 4ed34403f56198d7596812358037b2f28f374dab
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T19:40:30Z

    Use allInterfaceMethods instead of bean class.

commit ecd360d1c5f5d627404924f0007ea14167db80e1
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T18:48:01Z

    Incorporate diffs.

commit 2fa42004d9a125419fc479e05ba4200759882df4
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T18:56:30Z

    Add test for conflicting types.

commit bb013aa2f6f9b356f8f44b8e919ba11d4fcfafb6
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T20:16:43Z

    Commit latest changes.

commit ea47ac6a560c3dff9769182a5b47a8e623ad99c7
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T20:18:41Z

    Latest changes.

commit 9de21e91743a8683302c292b65f8228bfe6def2e
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T20:47:57Z

    Add exotic tests.

commit f0aa12fe248b1b0cdc67b995b8262985e361a1e3
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T21:05:37Z

    Fix tests and style issues.

commit 87a2641d759124e20209943ae5e4def72857c751
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T23:27:25Z

    Fix issue with multiple property definitions.

commit 025831de62f450146f17531f1795c0208b8d2bcf
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-22T23:55:49Z

    Disable bean test temporarily.

commit 85bd9c24c3bfae5a73989fa83316225bfc6bf51e
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-23T04:43:07Z

    Fix handling of non-bean methods to remove false positives but still be useful.

commit 551c69348f59c20899c3a07194929543f3b50875
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-09-23T06:09:31Z

    Update PipelineOptionsFactoryTest.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message