Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1D85B200B6B for ; Fri, 26 Aug 2016 00:02:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 165D8160ABD; Thu, 25 Aug 2016 22:01:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5B7B5160AA5 for ; Fri, 26 Aug 2016 00:01:45 +0200 (CEST) Received: (qmail 93705 invoked by uid 500); 25 Aug 2016 22:01:34 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 93695 invoked by uid 99); 25 Aug 2016 22:01:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 22:01:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2FDFE18059D for ; Thu, 25 Aug 2016 22:01:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DZdXPoweFXPz for ; Thu, 25 Aug 2016 22:01:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 6E8075F1B3 for ; Thu, 25 Aug 2016 22:01:32 +0000 (UTC) Received: (qmail 93679 invoked by uid 99); 25 Aug 2016 22:01:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 22:01:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 94F0EE040F; Thu, 25 Aug 2016 22:01:31 +0000 (UTC) From: tgroh To: commits@beam.incubator.apache.org Reply-To: commits@beam.incubator.apache.org Message-ID: Subject: [GitHub] incubator-beam pull request #886: Make WriteTest more resilient to Randomnes... Content-Type: text/plain Date: Thu, 25 Aug 2016 22:01:31 +0000 (UTC) archived-at: Thu, 25 Aug 2016 22:02:06 -0000 GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/886 Make WriteTest more resilient to Randomness Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- In the worst case scenario for random key assignment in Write.ApplyShardingKey, the chance of the number of records per output shard was too high. This makes the test significantly less likely to flake. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam balance_resilience Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/886.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #886 ---- commit ebafc8154ce8d2ad981e060042a74858e1a419ce Author: Thomas Groh Date: 2016-08-25T21:58:56Z Make WriteTest more resilient to Randomness In the worst case scenario for random key assignment in Write.ApplyShardingKey, the chance of the number of records per output shard was too high. This makes the test significantly less likely to flake. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---