Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: sammcveety <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-852-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #852: Correctly type collections in PipelineOpti...
Content-Type: text/plain
Date: Fri, 19 Aug 2016 00:56:58 +0000 (UTC)
archived-at: Fri, 19 Aug 2016 00:57:04 -0000

GitHub user sammcveety opened a pull request:

    https://github.com/apache/incubator-beam/pull/852

    Correctly type collections in PipelineOptions.

    @bjchambers @lukecwik I would expect this to work, but the cast to ParameterizedType fails.  Luke, were you suggesting something else?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/fix_generic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #852
    
----
commit bbb8e5a704564b989c8a19941b610e14c685e3c5
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:49:05Z

    Correctly type collections in PipelineOptions.

commit 9dc397915d2055b8be89abb92ccb2c8c7872a294
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:53:29Z

    Minor fix.

commit 77c77f0010142c65f896aa4a431bd50ab7e45f96
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-08-19T00:54:16Z

    Minor fix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---