Return-Path: <commits-return-8338-archive-asf-public=cust-asf.ponee.io@beam.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BDB12200B76
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 16 Aug 2016 00:45:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id BC3F5160AB8; Mon, 15 Aug 2016 22:45:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0E5F6160AA7
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 16 Aug 2016 00:44:59 +0200 (CEST)
Received: (qmail 74196 invoked by uid 500); 15 Aug 2016 22:44:59 -0000
Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.incubator.apache.org>
List-Post: <mailto:commits@beam.incubator.apache.org>
List-Id: <commits.beam.incubator.apache.org>
Reply-To: dev@beam.incubator.apache.org
Delivered-To: mailing list commits@beam.incubator.apache.org
Received: (qmail 74182 invoked by uid 99); 15 Aug 2016 22:44:59 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 22:44:59 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C8B93C000A
	for <commits@beam.apache.org>; Mon, 15 Aug 2016 22:44:58 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id W3LR_LSiTlvB for <commits@beam.apache.org>;
	Mon, 15 Aug 2016 22:44:58 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 31ED95FBB9
	for <commits@beam.incubator.apache.org>; Mon, 15 Aug 2016 22:44:57 +0000 (UTC)
Received: (qmail 74148 invoked by uid 99); 15 Aug 2016 22:44:56 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 22:44:56 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 44A6CE0556; Mon, 15 Aug 2016 22:44:56 +0000 (UTC)
From: vikkyrk <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-833-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #833: [BEAM-550] DatastoreIO Sink as ParDo
Content-Type: text/plain
Date: Mon, 15 Aug 2016 22:44:56 +0000 (UTC)
archived-at: Mon, 15 Aug 2016 22:45:00 -0000

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/incubator-beam/pull/833

    [BEAM-550] DatastoreIO Sink as ParDo

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    - DatastoreIO doesn't have an atomic operations, making WriteOperation#(initialize/finalize) a noop. There is no benefit for the additional complexity the Sink API brings. Hence cleaning up those classes and directly using a ParDo to implement Datastore writes.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam vikasrk/datastore_sink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #833
    
----
commit 3ad876dddbf3affe39093a748578aa5d93f7b4e0
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-08-15T22:28:07Z

    DatastoreIO Sink as ParDo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---