Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Tue, 16 Aug 2016 18:21:20 +0000 (UTC)
From: "Mariusz Wojakowski (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12990474.1468860723000.320615.1471371680558@Atlassian.JIRA>
In-Reply-To: <JIRA.12990474.1468860723000@Atlassian.JIRA>
References: <JIRA.12990474.1468860723000@Atlassian.JIRA> <JIRA.12990474.1468860723291@arcas>
Subject: [jira] [Commented] (BEAM-469) NullableCoder should encode using the
 context given and not always use the nested context
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 16 Aug 2016 18:21:24 -0000


    [ https://issues.apache.org/jira/browse/BEAM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423190#comment-15423190 ] 

Mariusz Wojakowski commented on BEAM-469:
-----------------------------------------

[~dhalperi@google.com]
Sorry, but I don't understand it yet. The {{NullableCoder}} delegates task to inner coder so: it (inner) needs to write down the length. Also the context passed to this (inner) coder must be nested because later someone can put other elements.

{{(1 (4 abcd)) (0) (1 (1 3 key 5 value))}}
(/\ example of {{NullableCoder}} with {{StringUtf8Coder}} & {{KvCoder}})

Maybe I mixed something up. Sorry for bothering you and thanks in advance!


> NullableCoder should encode using the context given and not always use the nested context
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-469
>                 URL: https://issues.apache.org/jira/browse/BEAM-469
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Trivial
>             Fix For: Not applicable
>
>
> NullableCoder should encode using the context given and not always use the nested context. For coders which can efficiently encode in the outer context such as StringUtf8Coder or ByteArrayCoder, we are forcing them to prefix themselves with their length.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)