Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7E577200B68 for ; Fri, 19 Aug 2016 21:58:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7CD99160AAB; Fri, 19 Aug 2016 19:58:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C21D6160A79 for ; Fri, 19 Aug 2016 21:58:24 +0200 (CEST) Received: (qmail 92523 invoked by uid 500); 19 Aug 2016 19:58:24 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 92514 invoked by uid 99); 19 Aug 2016 19:58:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Aug 2016 19:58:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 77B0118023E for ; Fri, 19 Aug 2016 19:58:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DGEbkDWjEm-6 for ; Fri, 19 Aug 2016 19:58:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A47675F30E for ; Fri, 19 Aug 2016 19:58:21 +0000 (UTC) Received: (qmail 92270 invoked by uid 99); 19 Aug 2016 19:58:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Aug 2016 19:58:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BF78D2C014F for ; Fri, 19 Aug 2016 19:58:20 +0000 (UTC) Date: Fri, 19 Aug 2016 19:58:20 +0000 (UTC) From: "Daniel Halperin (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-146) WindowFn.AssignContext leaks implementation details about compressed WindowedValue representation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 19 Aug 2016 19:58:25 -0000 [ https://issues.apache.org/jira/browse/BEAM-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Halperin updated BEAM-146: --------------------------------- Issue Type: Improvement (was: Bug) > WindowFn.AssignContext leaks implementation details about compressed WindowedValue representation > ------------------------------------------------------------------------------------------------- > > Key: BEAM-146 > URL: https://issues.apache.org/jira/browse/BEAM-146 > Project: Beam > Issue Type: Improvement > Components: beam-model > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Minor > Fix For: 0.2.0-incubating > > > Today, {{WindowFn.AssignContext}} provides simultaneous access to all of the windows that a value has been placed in. > Providing access to the current window for a value is convenient for, e.g. converting day windows to hour windows for each hour of the assign day. But providing access to all the assigned windows allows spooky action across windows, and is generally not intended to be observable - elements are semantically considered to be "duplicated" into each of the assigned windows. > This ticket proposes that the {{AssignContext}} should provide only a single window, and that windows should be "exploded" prior to window re-assignment so that elements are only observed within one window at a time. This can be accomplished trivially today via surgical insertion of {{RequiresWindowAccess}} but the {{AssignContext}} should have its API adjusted to be explicit about it, too. > This will affect only pipelines for which _all_ of the following hold: > - assigns to sliding windows (or custom {{WindowFn}} that places each element in multiple windows) > - re-assigns to different windows without a {{GroupByKey}} between. > - the new window assignment actually does depend on the full set of windows assigned > I hypothesize the number of such pipelines is zero. > I expect to address this during the Beam Runner API design. -- This message was sent by Atlassian JIRA (v6.3.4#6332)