beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JasonMWhite <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #853: [BEAM-409] Ensure precision in division of...
Date Fri, 19 Aug 2016 13:51:51 GMT
GitHub user JasonMWhite opened a pull request:

    https://github.com/apache/incubator-beam/pull/853

    [BEAM-409] Ensure precision in division of Longs in ApproximateQuantilesCombineFn

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This PR resolves [BEAM-409](https://issues.apache.org/jira/browse/BEAM-409) by casting
a long to a float before division.
    
    @swegner Would you mind reviewing for me?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JasonMWhite/incubator-beam fix_beam_409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #853
    
----
commit 8a2bc49c1a7ae2467fc2cbbdaad6d10c1411dd16
Author: Jason White <jason.white@shopify.com>
Date:   2016-08-19T13:46:52Z

    cast long to float before division to ensure precision

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message