beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #851: [BEAM-124] Modify example dependencies to ...
Date Thu, 18 Aug 2016 23:46:32 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/851

    [BEAM-124] Modify example dependencies to only add runners as optional dependencies

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Also support excluding runners by disabling the include-runners profile.
    
    Tested ITs
    BQ and WordCount pass on Dataflow
    WordCount passes on Flink and Spark
    
    Upfront setup:
    ```
    mvn clean install -pl examples/java,examples/java8 -am
    ```
    
    Dataflow:
    ```
    mvn clean verify -pl examples/java -DskipITs=false -DintegrationTestPipelineOptions='[
"--tempRoot=gs://clouddfe-testing-temp-storage", "--runner=org.apache.beam.runners.dataflow.testing.TestDataflowRunner"
]'
    ```
    
    Flink:
    ```
    mvn clean verify -pl examples/java -DskipITs=false -DintegrationTestPipelineOptions='[
"--tempRoot=gs://clouddfe-testing-temp-storage", "--runner=org.apache.beam.runners.flink.TestFlinkRunner"
]' -Dit.test=WordCountIT
    ```
    
    Spark:
    ```
    mvn clean verify -pl examples/java -DskipITs=false -DintegrationTestPipelineOptions='[
"--tempRoot=/tmp", "--runner=org.apache.beam.runners.spark.SparkRunner" ]' -Dit.test=WordCountIT
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam examples-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #851
    
----
commit 41273bcc40551d8bb36127ee775d2e21bf9194cd
Author: Luke Cwik <lcwik@google.com>
Date:   2016-08-18T23:35:33Z

    Modify example dependencies to only add runners as optional dependencies.
    Also support excluding runners by disabling the include-runners profile.
    
    Tested ITs
    BQ and WordCount pass on Dataflow
    WordCount passes on Flink and Spark

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message