beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #842: [BEAM-557] Fix repackaging exclude pattern...
Date Wed, 17 Aug 2016 16:30:33 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/842

    [BEAM-557] Fix repackaging exclude pattern for guava-testlib

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The previous fix was incorrect in that the exclude pattern requires `.*` at the end. Tested
this iteration using `javap` to inspect generated `.class` files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam guava-testlib

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #842
    
----
commit 2a8ceed623e7909e0d67b71263e255e10a1c7693
Author: Scott Wegner <swegner@google.com>
Date:   2016-08-17T16:28:44Z

    Fix repackaging exclude pattern for guava-testlib

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message