beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #799: Use EqualsTester in ProxyInvocationHandler...
Date Fri, 05 Aug 2016 22:22:15 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/799

    Use EqualsTester in ProxyInvocationHandlerTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This tests the equality groups instead of manual assertions, including
    same-reference equality.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam equals_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #799
    
----
commit 6b5cb3b83ffb0bb348122767a7d8a65bdf89a45e
Author: Thomas Groh <tgroh@google.com>
Date:   2016-08-05T22:21:12Z

    Use EqualsTester in ProxyInvocationHandlerTest
    
    This tests the equality groups instead of manual assertions, including
    same-reference equality.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message