beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] incubator-beam pull request #795: Minor Cleanups in the Direct Runner
Date Fri, 05 Aug 2016 17:07:25 GMT
GitHub user tgroh opened a pull request:

    Minor Cleanups in the Direct Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Consistent use of clock.
    Add a new test for DirectRunner Pipeline Reuse
    Remove unnecessary assignment.

You can merge this pull request into a Git repository by running:

    $ git pull direct_cleanups

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #795
commit 7585cfc3693800b00c4ccc799c27f0311e9b0cc1
Author: Thomas Groh <>
Date:   2016-08-05T16:58:05Z

    Remove References to Instant#now in the DirectRunner
    The DirectRunner should use exclusively the configured clock to
    determine the processing time.

commit 4546fd9c5e073eb33787faa302b8695dfd6e04aa
Author: Thomas Groh <>
Date:   2016-08-05T16:58:59Z

    Add DirectRunner Reuse Test
    Two calls to run using the Direct Runner should be independent and
    succeed independently.

commit acf71d313a43c8f39213ce19277ffebadcc40a77
Author: Thomas Groh <>
Date:   2016-08-05T16:59:46Z

    Remove unneccssary Assignment in TransformExecutor


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message