beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #768: Move test-jar back to default profile
Date Tue, 02 Aug 2016 20:58:48 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/768

    Move test-jar back to default profile

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    
    The test jars for beam-sdks-java-core and beam-runners-core-java are both mandatory artifacts
with testing utilities intended for general use. These were moved out of the default profile
since for most normal projects they are optional release-time distributions, but for us they
are not.
    
    R: @dhalperi @jbonofre 
    
    It may be that these should just be done in the particular modules that intend to really
distribute their tests for users. I'm not sure if it is just the two I mention in the commit
message, or if there are more. For example, the `beam-examples-java` tests and various IO
modules' tests are intended for use as integration tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam test-jar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/768.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #768
    
----
commit ec6959115e9d68b5d2a8d49ca99760b0669f12e4
Author: Kenneth Knowles <klk@google.com>
Date:   2016-08-02T20:55:13Z

    Move test-jar back to default profile
    
    The test jars for beam-sdks-java-core and
    beam-runners-core-java are both mandatory artifacts
    with testing utilities intended for general use.
    
    These were moved out of the default profile since for most
    normal projects they are optional release-time distributions,
    but for us they are not.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message