beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #764: Add ElementByteSizeObserver default constr...
Date Mon, 01 Aug 2016 21:57:59 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/764

    Add ElementByteSizeObserver default constructor

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This enables constructing an observer without the Counter to simplify
    testing and use with other ways of reporting byte size.
    
    Once compatibility issues are resolved, the class will become abstract
    with the Counter-specific functionality removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam element-byte-size-observer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #764
    
----
commit 243edfec7e2593dcf8c49541da437a3a6744b5d6
Author: bchambers <bchambers@google.com>
Date:   2016-08-01T17:37:14Z

    Add ElementByteSizeObserver default constructor
    
    This enables constructing an observer without the Counter to simplify
    testing and use with other ways of reporting byte size.
    
    Once compatibility issues are resolved, the class will become abstract
    with the Counter-specific functionality removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message