beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [1/2] incubator-beam git commit: Made byteArrayCoder final static
Date Thu, 11 Aug 2016 05:11:21 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master 2a1055dd8 -> 869ba7d82


Made byteArrayCoder final static


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/4e7814f7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/4e7814f7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/4e7814f7

Branch: refs/heads/master
Commit: 4e7814f716bba02a2eb1d71f61a95d081b035346
Parents: 2a1055d
Author: gaurav gupta <gaugupt3@cisco.com>
Authored: Wed Aug 10 16:43:03 2016 -0700
Committer: gaurav gupta <gaugupt3@cisco.com>
Committed: Wed Aug 10 21:26:16 2016 -0700

----------------------------------------------------------------------
 .../build-tools/src/main/resources/beam/findbugs-filter.xml    | 6 ------
 .../src/main/java/org/apache/beam/sdk/util/BitSetCoder.java    | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/4e7814f7/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
----------------------------------------------------------------------
diff --git a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
index 1ad7988..d135cbb 100644
--- a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
+++ b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml
@@ -110,12 +110,6 @@
     <!--[BEAM-412] Non-transient non-serializable instance field in serializable class-->
   </Match>
   <Match>
-    <Class name="org.apache.beam.sdk.util.BitSetCoder"/>
-    <Field name="byteArrayCoder"/>
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
-    <!--[BEAM-418] Transient field that isn't set by deserialization. -->
-  </Match>
-  <Match>
     <Class name="org.apache.beam.sdk.util.CombineFnUtil$NonSerializableBoundedKeyedCombineFn"/>
     <Field name="context"/>
     <Bug pattern="SE_BAD_FIELD"/>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/4e7814f7/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BitSetCoder.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BitSetCoder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BitSetCoder.java
index 82c5f51..b406b1a 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BitSetCoder.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BitSetCoder.java
@@ -32,7 +32,7 @@ import java.util.BitSet;
 class BitSetCoder extends AtomicCoder<BitSet> {
 
   private static final BitSetCoder INSTANCE = new BitSetCoder();
-  private transient ByteArrayCoder byteArrayCoder = ByteArrayCoder.of();
+  private static final ByteArrayCoder byteArrayCoder = ByteArrayCoder.of();
 
   private BitSetCoder() {}
 


Mime
View raw message