beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-409) Incorrect use of Math.ceil in ApproximateQuantiles
Date Fri, 19 Aug 2016 13:52:20 GMT


ASF GitHub Bot commented on BEAM-409:

GitHub user JasonMWhite opened a pull request:

    [BEAM-409] Ensure precision in division of Longs in ApproximateQuantilesCombineFn

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This PR resolves [BEAM-409]( by casting
a long to a float before division.
    @swegner Would you mind reviewing for me?

You can merge this pull request into a Git repository by running:

    $ git pull fix_beam_409

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #853
commit 8a2bc49c1a7ae2467fc2cbbdaad6d10c1411dd16
Author: Jason White <>
Date:   2016-08-19T13:46:52Z

    cast long to float before division to ensure precision


> Incorrect use of Math.ceil in ApproximateQuantiles
> --------------------------------------------------
>                 Key: BEAM-409
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
Integral value cast to double and then passed to Math.ceil
> Applies to: [ApproximateQuanitles|].
> This is a good starter bug. When fixing, please remove the corresponding entries from
and verify the build passes.

This message was sent by Atlassian JIRA

View raw message