beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [1/2] incubator-beam git commit: Bind checkstyle:check to the test-compile phase to fail earlier
Date Thu, 04 Aug 2016 00:05:03 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master da31a2d77 -> ca15cac0a


Bind checkstyle:check to the test-compile phase to fail earlier


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/1fecb284
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/1fecb284
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/1fecb284

Branch: refs/heads/master
Commit: 1fecb2844c0b7e6cdedb93d93164d2151c847f98
Parents: da31a2d
Author: Kenneth Knowles <klk@google.com>
Authored: Wed Aug 3 16:12:15 2016 -0700
Committer: Kenneth Knowles <klk@google.com>
Committed: Wed Aug 3 16:12:15 2016 -0700

----------------------------------------------------------------------
 pom.xml | 8 ++++++++
 1 file changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/1fecb284/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 3b98382..23b7e4d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -703,7 +703,15 @@
             <includeTestSourceDirectory>true</includeTestSourceDirectory>
           </configuration>
           <executions>
+            <!--
+              Execute checkstyle after compilation but before tests.
+
+              This ensures that any parsing or type checking errors are from
+              javac, so they look as expected. Beyond that, we want to
+              fail as early as possible.
+            -->
             <execution>
+              <phase>test-compile</phase>
               <goals>
                 <goal>check</goal>
               </goals>


Mime
View raw message