Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: swegner <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-574-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #574: Fix, suppress, or file bugs for FindBugs i...
Content-Type: text/plain
Date: Fri,  1 Jul 2016 18:35:42 +0000 (UTC)
archived-at: Fri, 01 Jul 2016 18:35:48 -0000

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/574

    Fix, suppress, or file bugs for FindBugs issues

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    When adding FindBugs integration, many existing issues were uncovered. Of those issues, some are trivial to fix, some are more complicated, and some are unimportant or false positive. This PR goes through and triages the existing baseline issues. For each:
    
    * Unimportant / false positive: Move to inline suppression with justification ([example](https://github.com/apache/incubator-beam/compare/master...swegner:findbugs-stale?expand=1#diff-c1df753c9b67cc72f7beed77779eaa90R64))
    * Trivial fix: Fixed inline ([example](https://github.com/apache/incubator-beam/compare/master...swegner:findbugs-stale?expand=1#diff-d6c918ab6169a2f61f4902c6018778f3R351))
    * Non-trivial fix needed: Opened bug and tagged baseline suppression ([example](https://github.com/apache/incubator-beam/compare/master...swegner:findbugs-stale?expand=1#diff-6bffc9239f6c94cf1540559353cd868dR36))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam findbugs-stale

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #574
    
----
commit c542117c48ce7983b363d676220392cd12b88ed7
Author: Scott Wegner <swegner@google.com>
Date:   2016-06-30T23:16:14Z

    Fix and file bugs for FindBugs issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---