Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Wed, 27 Jul 2016 20:24:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12992905.1469621582000.150299.1469651060835@Atlassian.JIRA>
In-Reply-To: <JIRA.12992905.1469621582000@Atlassian.JIRA>
References: <JIRA.12992905.1469621582000@Atlassian.JIRA> <JIRA.12992905.1469621582384@arcas>
Subject: [jira] [Commented] (BEAM-492) Spark runner should call
 Pipeline.run() instead of SparkRunner.run()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 27 Jul 2016 20:24:25 -0000


    [ https://issues.apache.org/jira/browse/BEAM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396288#comment-15396288 ] 

ASF GitHub Bot commented on BEAM-492:
-------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/incubator-beam/pull/743

    [BEAM-492] Spark runner should call Pipeline.run() instead of SparkRunner.run()

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/incubator-beam BEAM-492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #743
    
----
commit 6db286e91bb5a72d46f9ac71aad5f20799faa885
Author: Sela <ansela@paypal.com>
Date:   2016-07-27T20:11:37Z

    Remove SparkStreamingPipelineOptions.

commit dcc107323ffdb6121b7e2ca11af4409cac4bb7a8
Author: Sela <ansela@paypal.com>
Date:   2016-07-27T20:11:56Z

    Run pipeline with Pipeline.run().

----


> Spark runner should call Pipeline.run() instead of SparkRunner.run()
> --------------------------------------------------------------------
>
>                 Key: BEAM-492
>                 URL: https://issues.apache.org/jira/browse/BEAM-492
>             Project: Beam
>          Issue Type: Bug
>    Affects Versions: 0.1.0-incubating
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> Currently, in some places (streaming examples, etc.), the Pipeline executes by calling SparkRunner.run() instead of calling Pipeline.run() which is kind of "backwards" to the Beam API.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)