Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Tue, 26 Jul 2016 12:07:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12992563.1469534536000.133959.1469534840565@Atlassian.JIRA>
In-Reply-To: <JIRA.12992563.1469534536000@Atlassian.JIRA>
References: <JIRA.12992563.1469534536000@Atlassian.JIRA> <JIRA.12992563.1469534536828@arcas>
Subject: [jira] [Commented] (BEAM-489) remove headerLocation from
 maven-checkstyle-plugin configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 26 Jul 2016 12:07:25 -0000


    [ https://issues.apache.org/jira/browse/BEAM-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393694#comment-15393694 ] 

ASF GitHub Bot commented on BEAM-489:
-------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-beam/pull/734

    [BEAM-489] remove headerLocation from maven-checkstyle-plugin

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-beam BEAM-489

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #734
    
----
commit 7a5651763d73ef78f5e11c95631576024ff5efac
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2016-07-26T12:05:37Z

    [BEAM-489] remove headerLocation from maven-checkstyle-plugin

----


> remove headerLocation from maven-checkstyle-plugin configuration 
> -----------------------------------------------------------------
>
>                 Key: BEAM-489
>                 URL: https://issues.apache.org/jira/browse/BEAM-489
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>    Affects Versions: 0.1.0-incubating
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>            Priority: Trivial
>
> As license header has been checked by maven-rat-plugin since BEAM-254, headerLocation in the maven-checkstyle-plugin is redundant.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)