beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <>
Subject [GitHub] incubator-beam pull request #753: [BEAM-436] Re-enable RunnableOnService tes...
Date Thu, 28 Jul 2016 20:39:35 GMT
GitHub user swegner opened a pull request:

    [BEAM-436] Re-enable RunnableOnService tests which need tempRoot

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    @peihe's recent work to improve tempRoot handling means that these tests are now working
properly. They can be re-enabled to validate runner display data for i/o transforms.

You can merge this pull request into a Git repository by running:

    $ git pull io-runnableonservice

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #753
commit e741f32184838f598d351117e024995ff4f5d3fe
Author: Scott Wegner <>
Date:   2016-07-28T20:35:55Z

    Re-enable RunnableOnService tests which need tempRoot


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message