beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #710: [BEAM-479] Move local Flink integration te...
Date Fri, 22 Jul 2016 04:20:37 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/710

    [BEAM-479] Move local Flink integration tests to a profile

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    These tests are now activated by Jenkins in the intended way, the same as Dataflow, via
`mvn -DrunnableOnServicePipelineOptions=...`
    
    Since a local configuration is convenient and canonical, it is also valuable to have them
in the config, so I have put them in a profile where the option string is hardcoded. This
can be activated on the with `mvn -P local-runnable-on-service-tests`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam remove-flink-local

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #710
    
----
commit e4897fd84966b8c141d1e84b2a3823ed1ea40b8e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-21T21:54:17Z

    Move local Flink integration tests to a profile
    
    These tests can now be activated on the commandline
    with -P local-runnable-on-service-tests and are
    activated directly by Jenkins.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message