beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <>
Subject [GitHub] incubator-beam pull request #648: [BEAM-445] Switch to netty-tcnative uber-j...
Date Wed, 13 Jul 2016 20:44:12 GMT
GitHub user swegner opened a pull request:

    [BEAM-445] Switch to netty-tcnative uber-jar dependency

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Currently, we are using the os-maven-plugin extension to compute the platform-specific
version of the netty-tcnative dependency to use in gcp-io. Unfortunately, netty-tcnative is
a transitive dependency and all pom's which depend on gcp-io (directly or transitively) also
need to declare the os-maven-plugin dependency.
    This PR removes os-maven-plugin and it's dynamic resolution. We instead depend on the
"uber jar" version of netty-tcnative, which includes all platform-native versions.

You can merge this pull request into a Git repository by running:

    $ git pull os-maven-plugin

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #648
commit 55ed28eb4d8305ca1968d9b012b22779814d0a44
Author: Scott Wegner <>
Date:   2016-07-12T23:20:10Z

    Remove netty-tcnative dynamic os dependency


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message