beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #609: [BEAM-431] Move example dependency on runn...
Date Fri, 08 Jul 2016 02:53:42 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/609

    [BEAM-431] Move example dependency on runners into a profile

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Even an optional runtime dependency, such as from the examples
    to a runner, does get pulled in for testing. This meant that
    all the dependencies for all runners had to be resolvable in an
    integration testing context. It is quite inconvenient.
    
    Explicitly excluding runners via flags such as `-pl !runners/spark`
    does not work since it causes errors in dependency resolution.
    
    This change adds a profile, active by default, that can be
    explicitly disabled to avoid pulling in dependencies.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam no-runners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #609
    
----
commit c17768f14f5a57bcc2d83613818101f3b21e7260
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-08T02:41:45Z

    Move example dependency on runners into a profile
    
    Even an optional runtime dependency, such as from the examples
    to a runner, does get pulled in for testing. This meant that
    all the dependencies for all runners had to be resolvable in an
    integration testing context. It is quite inconvient.
    
    Explicitly excluding runners via flags such as `-pl !runners/spark`
    does not work since it causes errors in dependency resolution.
    
    This change adds a profile, active by default, that can be
    explicitly disabled to avoid pulling in dependencies.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message