beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #597: pipeline.options should never be None
Date Wed, 06 Jul 2016 23:47:09 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/incubator-beam/pull/597

    pipeline.options should never be None

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Also fix a typehints error this exposed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam pipeline-options

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #597
    
----
commit 0d6603efbc55a79c1ce6e7255c23c92b2478aa66
Author: Robert Bradshaw <robertwb@google.com>
Date:   2016-07-06T23:36:50Z

    pipeline.options should never be None
    
    Also fix a typehints error this exposed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message