beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lucasallan <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #591: [BEAM-413] - Improves test for floating po...
Date Wed, 06 Jul 2016 04:22:09 GMT
GitHub user lucasallan opened a pull request:

    https://github.com/apache/incubator-beam/pull/591

    [BEAM-413] - Improves test for floating point equality.

    This operation compares two floating point values for equality. Because
    floating point calculations may involve rounding, calculated float and
    double values may not be accurate. For values that must be precise, such
    as monetary values, consider using a fixed-precision type such as
    BigDecimal. For values that need not be precise, consider comparing for
    equality within some range, for example: if ( Math.abs(x - y) < .0000001
    ).
    
    For more information: https://issues.apache.org/jira/browse/BEAM-413

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucasallan/incubator-beam beam-413

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #591
    
----
commit 231a93ef16e781c01a33947f3c9a3173eaeba899
Author: Lucas Amorim <lucasamorim@lucass-mbp.hitronhub.home>
Date:   2016-07-06T04:19:08Z

    [BEAM-413] - Improves test for floating point equality.
    
    This operation compares two floating point values for equality. Because
    floating point calculations may involve rounding, calculated float and
    double values may not be accurate. For values that must be precise, such
    as monetary values, consider using a fixed-precision type such as
    BigDecimal. For values that need not be precise, consider comparing for
    equality within some range, for example: if ( Math.abs(x - y) < .0000001
    ).
    
    For more information: https://issues.apache.org/jira/browse/BEAM-413

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message