beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #573: [BEAM-145] Fix timestamps in GroupAlsoByWi...
Date Fri, 01 Jul 2016 16:56:29 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-145] Fix timestamps in GroupAlsoByWindowsProperties

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Some of the timestamps were not adjusted when [BEAM-145](
was fixed to respect the `WindowFn`'s timestamps.

You can merge this pull request into a Git repository by running:

    $ git pull GABWProperties

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #573
commit 190740f7971be506df5416dc4dfc5714bba0c972
Author: Kenneth Knowles <>
Date:   2016-07-01T16:53:37Z

    Fix timestamps in GroupAlsoByWindowsProperties
    Some of the timestamps were not adjusted when
    BEAM-145 was fixed to respect the WindowFn's


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message