beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-499) Remove unused code in apiclient.py and iobase.py
Date Fri, 29 Jul 2016 23:58:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400271#comment-15400271
] 

ASF GitHub Bot commented on BEAM-499:
-------------------------------------

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/incubator-beam/pull/763

    [BEAM-499] Deletes some code that is not used by SDK.

    Some code in apiclient.py is not used by Python SDK.
    
    Deleting unused code and corresponding tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/incubator-beam delete_unused_apiclient_code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #763
    
----
commit 7d50d8040585e0cea5bc02de4cb199f29c1472fc
Author: Chamikara Jayalath <chamikara@google.com>
Date:   2016-07-29T22:40:39Z

    Deletes some code that is not used by SDK.
    
    Also deletes corresponding tests.

----


> Remove unused code in apiclient.py and iobase.py
> ------------------------------------------------
>
>                 Key: BEAM-499
>                 URL: https://issues.apache.org/jira/browse/BEAM-499
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> There is some code in apiclient.py and iobase.py that is not used by Dataflow SDK. This
code has to be removed.
> E.g.:
> class DataflowWorkerClient
> def reader_progress_to_cloud_progress() and other similar methods.
> def splits_to_split_response()
> class ConcatPosition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message