beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-479) Move RunnableOnService test executions to postcommit
Date Fri, 22 Jul 2016 04:21:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388886#comment-15388886
] 

ASF GitHub Bot commented on BEAM-479:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/710

    [BEAM-479] Move local Flink integration tests to a profile

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    These tests are now activated by Jenkins in the intended way, the same as Dataflow, via
`mvn -DrunnableOnServicePipelineOptions=...`
    
    Since a local configuration is convenient and canonical, it is also valuable to have them
in the config, so I have put them in a profile where the option string is hardcoded. This
can be activated on the with `mvn -P local-runnable-on-service-tests`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam remove-flink-local

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #710
    
----
commit e4897fd84966b8c141d1e84b2a3823ed1ea40b8e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-21T21:54:17Z

    Move local Flink integration tests to a profile
    
    These tests can now be activated on the commandline
    with -P local-runnable-on-service-tests and are
    activated directly by Jenkins.

----


> Move RunnableOnService test executions to postcommit
> ----------------------------------------------------
>
>                 Key: BEAM-479
>                 URL: https://issues.apache.org/jira/browse/BEAM-479
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow, runner-flink, runner-gearpump, runner-spark
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> The Spark and Flink RunnableOnService tests only use a local endpoint, so they _can_
run as unit tests, but our test duration is getting out of hand. For Gearpump, the tests timeout.
So this ticket tracks getting everyone to a symmetric configuration.
> Later, we can re-enable a select few local endpoint tests for the various runners, to
smoke test, and hopefully get actual cluster-based integration tests running on Jenkins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message