beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-474) Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner not @RunnableOnService
Date Fri, 29 Jul 2016 18:28:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399816#comment-15399816
] 

Kenneth Knowles commented on BEAM-474:
--------------------------------------

Keep in mind our general goal of splitting RunnableOnService into precise categories. I think
it is fair to say that today RunnableOnService is a misnomer and it is legitimate to interpret
it as "a test that is useful to run against a runner to check that the _runner_ is correct".
Display data tests fit into this, but please do feel free to make new useful categories.

Perhaps

 - RunnableOnService (maybe a name like RunnerExecutionTest) <: RunnerTest
 - RunnerConstructionTest <: RunnerTest


> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner
not @RunnableOnService
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-474
>                 URL: https://issues.apache.org/jira/browse/BEAM-474
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Minor
>
> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner
not @RunnableOnService
> @RunnableOnService represents tests which actually execute a Pipeline while @NeedsRunner
represents tests that need a runner to construct the pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message