beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Groh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-474) Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner not @RunnableOnService
Date Fri, 29 Jul 2016 17:06:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399690#comment-15399690
] 

Thomas Groh commented on BEAM-474:
----------------------------------

Any test that does not execute a Pipeline in the Core SDK should not be marked with `RunnableOnService`
or `NeedsRunner`. `RunnableOnService` tests are tests where assertions are done based on the
model in a runner-independent way (e.g. with PAssert or examining the PipelineResult object),
and `NeedsRunner` are sdk-core and runners-core tests that test PTransforms via executing
a pipeline, but not always in a runner-independent manner (e.g. they expect exceptions to
be thrown, which are not handled identically across runners)

> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner
not @RunnableOnService
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-474
>                 URL: https://issues.apache.org/jira/browse/BEAM-474
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Minor
>
> Tests which evaluate DisplayData but don't run a pipeline should be marked @NeedsRunner
not @RunnableOnService
> @RunnableOnService represents tests which actually execute a Pipeline while @NeedsRunner
represents tests that need a runner to construct the pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message