beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-468) NullableCoder should not ask valueCoder isRegisterByteSizeObserverCheap when value is null
Date Mon, 18 Jul 2016 20:16:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382979#comment-15382979
] 

ASF GitHub Bot commented on BEAM-468:
-------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/680

    [BEAM-468] NullableCoder should not ask valueCoder isRegisterByteSizeObserverCheap when
value is null

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam beam468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #680
    
----
commit c5030a0ebc09499a15704301703654cb34444547
Author: Luke Cwik <lcwik@google.com>
Date:   2016-07-18T20:14:33Z

    [BEAM-468] NullableCoder should not ask valueCoder isRegisterByteSizeObserverCheap when
value is null

----


> NullableCoder should not ask valueCoder isRegisterByteSizeObserverCheap when value is
null
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-468
>                 URL: https://issues.apache.org/jira/browse/BEAM-468
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Trivial
>
> The value coder may assume that the given value is always non-null and it would be an
error to pass it a null value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message